Change in vdsm[master]: gluster: get rdma port number as part of volume status.
barumuga at redhat.com
barumuga at redhat.com
Thu Jan 22 11:43:26 UTC 2015
Bala.FA has posted comments on this change.
Change subject: gluster: get rdma port number as part of volume status.
......................................................................
Patch Set 2: Code-Review-1
(1 comment)
http://gerrit.ovirt.org/#/c/36607/2/tests/gluster_cli_tests.py
File tests/gluster_cli_tests.py:
Line 302: 'hostuuid':
Line 303: 'f06b108e-a780-4519-bb22-c3083a1e3f8a',
Line 304: 'pid': '1357',
Line 305: 'port': '38467',
Line 306: 'rdma_port': 'N/A',
As port number is integer, I think it should return 0 for N/A. This way the consumer validate valid port than checking mixed type.
Line 307: 'status': 'ONLINE'}],
Line 308: 'shd': [{'hostname': '192.168.122.2',
Line 309: 'hostuuid':
Line 310: 'f06b108e-a780-4519-bb22-c3083a1e3f8a',
--
To view, visit http://gerrit.ovirt.org/36607
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5f31c3fc194f0113fdd707f59576835a4a9f2832
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Darshan N <dnarayan at redhat.com>
Gerrit-Reviewer: Bala.FA <barumuga at redhat.com>
Gerrit-Reviewer: Darshan N <dnarayan at redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose at redhat.com>
Gerrit-Reviewer: Timothy Asir <tjeyasin at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list