Change in vdsm[master]: hostdev: add support for reporting pci addresses

fromani at redhat.com fromani at redhat.com
Thu Jan 22 08:03:59 UTC 2015


Francesco Romani has posted comments on this change.

Change subject: hostdev: add support for reporting pci addresses
......................................................................


Patch Set 5:

(2 comments)

http://gerrit.ovirt.org/#/c/35651/5/vdsm/hostdev.py
File vdsm/hostdev.py:

Line 55:     return params
Line 56: 
Line 57: 
Line 58: def _parse_pci_address(caps):
Line 59:     return _parse_address(caps, ('domain', 'bus', 'slot', 'function'))
> It's PCI bus standard, none of that can be missing (and if it is, we want t
Fair enough. Fine for me.
Line 60: 
Line 61: 
Line 62: def _parse_device_params(device_xml):
Line 63:     """


Line 102:     try:
Line 103:         params['addr'] = address_parser[params['capability']](caps)
Line 104:     except KeyError:
Line 105:         # We can somewhat safely ignore missing address as that means we're
Line 106:         # dealing with device that is not yet supported
> In case of capability, we would crash earlier, that should leave missing pa
fine for me.
Line 107:         pass
Line 108: 
Line 109:     return params
Line 110: 


-- 
To view, visit http://gerrit.ovirt.org/35651
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8208af6b662550de426d8d015421e0ab2c3c617e
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list