Change in vdsm[master]: net stats: add tx/rx statistic to getInterfacesStat

danken at redhat.com danken at redhat.com
Wed Jan 21 15:07:19 UTC 2015


Dan Kenigsberg has posted comments on this change.

Change subject: net stats: add tx/rx statistic to getInterfacesStat
......................................................................


Patch Set 15:

(1 comment)

http://gerrit.ovirt.org/#/c/35061/15/tests/functional/networkTests.py
File tests/functional/networkTests.py:

Line 456:             # running ARP from the interface
Line 457:             rc, out, err = execCmd([_ARPPING_COMMAND.cmd, '-D', '-I', left,
Line 458:                                     '-c', '1', IP_ADDRESS_IN_NETWORK])
Line 459:             if rc != 0:
Line 460:                 raise SkipTest('Could not run sysctl command', out, err)
also, this skiptest string is out of date.
Line 461:             # Sleep 2 seconds for the statistics to be updated
Line 462:             time.sleep(2)
Line 463:             curTxStat = getTxStatsFromInterface(left)
Line 464:             diff = (curTxStat - prevTxStat)


-- 
To view, visit http://gerrit.ovirt.org/35061
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I314a04570dec56677168e0fdb4a7824d299dbd65
Gerrit-PatchSet: 15
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Amir Shladovsky <a.shlado at gmail.com>
Gerrit-Reviewer: Amador Pahim <apahim at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <toni at midokura.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia at redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list