Change in vdsm[master]: packaging: Added pep8 and pyflakes submodules to vdsm source...

danken at redhat.com danken at redhat.com
Wed Jan 21 09:34:46 UTC 2015


Dan Kenigsberg has posted comments on this change.

Change subject: packaging: Added pep8 and pyflakes submodules to vdsm source tree
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.ovirt.org/#/c/37134/2//COMMIT_MSG
Commit Message:

Line 8: 
Line 9: Added these submodules to make the build of vdsm slightly smoother,
Line 10: as pep8 and pyflakes will not have to be manually installed any longer.
Line 11: Pep8 submodule from: https://github.com/jcrocholl/pep8
Line 12: Pyflakes submodule from: https://github.com/pyflakes/pyflakes/
Please add

 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1182088

do you plan to make `make check` use the utilities from the submodules? (I think you should)
Line 13: 
Line 14: Change-Id: I2248ad929b49684d41a40e944c907298deec4daa


-- 
To view, visit http://gerrit.ovirt.org/37134
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2248ad929b49684d41a40e944c907298deec4daa
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Candace Sheremeta <cshereme at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list