Change in vdsm[master]: networkTests: sort imports from Python libraries, separate 3...

osvoboda at redhat.com osvoboda at redhat.com
Wed Jan 21 01:46:00 UTC 2015


Ondřej Svoboda has posted comments on this change.

Change subject: networkTests: sort imports from Python libraries, separate 3rd party nosetests
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.ovirt.org/#/c/37034/2/tests/functional/networkTests.py
File tests/functional/networkTests.py:

Line 29: from hookValidation import ValidatesHook
Line 30: from network.sourceroute import StaticSourceRoute
Line 31: from testlib import (VdsmTestCase as TestCaseBase, namedTemporaryDir,
Line 32:                      expandPermutations, permutations)
Line 33: from testValidation import (brokentest, slowtest, RequireDummyMod,
> this should be also sorted (before testlib)
But why? Both are in the same directory. And I sort regardless of letter case (or even if and underscore was there, I would sort “naturally”).
Line 34:                             RequireVethMod, ValidateRunningAsRoot)
Line 35: 
Line 36: import dhcp
Line 37: import dummy


-- 
To view, visit http://gerrit.ovirt.org/37034
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I62c9ffa731bb71948970d080ff1c2cef88cb74f7
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list