Change in vdsm[master]: net stats: add tx/rx statistic to getInterfacesStat
danken at redhat.com
danken at redhat.com
Tue Jan 20 20:57:17 UTC 2015
Dan Kenigsberg has posted comments on this change.
Change subject: net stats: add tx/rx statistic to getInterfacesStat
......................................................................
Patch Set 14:
(2 comments)
http://gerrit.ovirt.org/#/c/35061/14/lib/vdsm/sysctl.py
File lib/vdsm/sysctl.py:
Line 37: set_rp_filter(dev, _RPFILTER_STRICT)
Line 38:
Line 39:
Line 40: def disable_ipv6(dev):
Line 41: with open('/proc/sys/net/ipv6/conf/%s/disable_ipv6' % (dev, ), 'w') as f:
> why is the dev in a tuple?
Done
http://gerrit.ovirt.org/#/c/35061/14/tests/functional/networkTests.py
File tests/functional/networkTests.py:
Line 431: status, msg, hostStats = self.vdsm_net.getVdsStats()
Line 432: self.assertEqual(status, SUCCESS, msg)
Line 433: self.assertIn('network', hostStats)
Line 434: self.assertIn(
Line 435: left, hostStats['network'], 'couldn''t find veth')
> $ print 'couldn''t find veth'
Done
Line 436:
Line 437: def getTxStatsFromInterface(iface):
Line 438: status, msg, hostStats = self.vdsm_net.getVdsStats()
Line 439: self.assertEqual(status, SUCCESS, msg)
--
To view, visit http://gerrit.ovirt.org/35061
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I314a04570dec56677168e0fdb4a7824d299dbd65
Gerrit-PatchSet: 14
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Amir Shladovsky <a.shlado at gmail.com>
Gerrit-Reviewer: Amador Pahim <apahim at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <toni at midokura.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia at redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list