Change in vdsm[master]: Simplify tests for qemuimg to allow additional capabilities ...
apahim at redhat.com
apahim at redhat.com
Tue Jan 20 12:05:18 UTC 2015
Amador Pahim has posted comments on this change.
Change subject: Simplify tests for qemuimg to allow additional capabilities checks
......................................................................
Patch Set 8:
(3 comments)
http://gerrit.ovirt.org/#/c/36366/8/tests/qemuimgTests.py
File tests/qemuimgTests.py:
Line 49
Line 50
Line 51
Line 52
Line 53
> We can replace FakeCmd in this class too with MonkeyPatchScope.
Done
Line 152: return 0, '', ''
Line 153:
Line 154: with MonkeyPatchScope([(qemuimg, '_supports_qcow2_compat',
Line 155: self.supported('create', False)),
Line 156: (utils, 'execCmd', create)]):
> pep8 is ok with this indentation, but it is not clear.
Done
Line 157: qemuimg.create('image', format='qcow2')
Line 158:
Line 159: def test_qcow2_compat_supported(self):
Line 160:
Line 260:
Line 261:
Line 262: class SupportsQcow2ComaptTests(TestCaseBase):
Line 263:
Line 264: def qcow2_compat_supported(cmd, **kw):
> This should be a module function and not an instance method as you created.
Done
Line 265: return 0, 'Supported options:\ncompat ...\n', ''
Line 266:
Line 267: def qcow2_compat_unsupported(cmd, **kw):
Line 268: return 0, 'Supported options:\nsize ...\n', ''
--
To view, visit http://gerrit.ovirt.org/36366
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I386772bf2a25a880b5ad387f284679eed81c5615
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Amador Pahim <apahim at redhat.com>
Gerrit-Reviewer: Amador Pahim <apahim at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list