Change in vdsm[master]: net stats: drop statsAge from statistics

danken at redhat.com danken at redhat.com
Tue Jan 20 10:41:08 UTC 2015


Dan Kenigsberg has posted comments on this change.

Change subject: net stats: drop statsAge from statistics
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.ovirt.org/#/c/36482/3/vdsm/rpc/vdsmapi-schema.json
File vdsm/rpc/vdsmapi-schema.json:

Line 6795:           'network': 'NetworkInterfaceStatsMap',
Line 6796:           'disks': 'VmDiskStatsMap', 'monitorResponse': 'int',
Line 6797:           'elapsedTime': 'uint', '*cdrom': 'str',
Line 6798:           '*boot': 'VmBootMode', 'cpuSys': 'float',
Line 6799:           'cpuUser': 'float',
> this could move to the upper line
I hate moving code just for the sake of saving line count. It confuses reviewers.
Line 6800:           'acpiEnable': 'bool', 'timeOffset': 'uint',
Line 6801:           'clientIp': 'str', 'pauseCode': 'str', 'memUsage': 'uint',
Line 6802:           'username': 'str', 'session': 'GuestSessionState',
Line 6803:           'appsList': ['str'], 'guestIPs': 'str',


-- 
To view, visit http://gerrit.ovirt.org/36482
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3f48e2eecc49bdf877056295b198725add1f792d
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Amir Shladovsky <a.shlado at gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia at redhat.com>
Gerrit-Reviewer: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list