Change in vdsm[master]: Handle iscsi iface.net_ifacename for existing iface
apahim at redhat.com
apahim at redhat.com
Mon Jan 19 14:31:45 UTC 2015
Amador Pahim has posted comments on this change.
Change subject: Handle iscsi iface.net_ifacename for existing iface
......................................................................
Patch Set 4:
(1 comment)
http://gerrit.ovirt.org/#/c/35976/4/vdsm/storage/hsm.py
File vdsm/storage/hsm.py:
Line 166: continue
Line 167:
Line 168: if netIfaceName is not None:
Line 169: if not _updateIfaceNameIfNeeded(iface, netIfaceName) and \
Line 170: netIfaceName != iface.netIfaceName:
> We prefer the parenthesis and a slightly different indentation (for readabi
Sure, np.
Line 171: logging.error('iSCSI netIfaceName coming from engine [%s] '
Line 172: 'is different from iface.net_ifacename '
Line 173: 'present on the system [%s]. Aborting iscsi '
Line 174: 'iface [%s] configuration.' %
--
To view, visit http://gerrit.ovirt.org/35976
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I18c2b92a75ee3bcbbcc546e2bfa4f133a5f9ad22
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Amador Pahim <apahim at redhat.com>
Gerrit-Reviewer: Amador Pahim <apahim at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list