Change in vdsm[master]: networkTests: sort imports from Python libraries (including ...

osvoboda at redhat.com osvoboda at redhat.com
Sun Jan 18 21:16:22 UTC 2015


Ondřej Svoboda has posted comments on this change.

Change subject: networkTests: sort imports from Python libraries (including 3rd party)
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.ovirt.org/#/c/37034/1/tests/functional/networkTests.py
File tests/functional/networkTests.py:

Line 19: from contextlib import contextmanager
Line 20: from functools import wraps
Line 21: import json
Line 22: import netaddr
Line 23: from nose import with_setup
> nose is not part of the stdlib, so it should come after signal, but before 
Okay! (This was the "3rd party" library I talked about in the commit message.)
Line 24: from nose.plugins.skip import SkipTest
Line 25: import os.path
Line 26: import signal
Line 27: 


-- 
To view, visit http://gerrit.ovirt.org/37034
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I62c9ffa731bb71948970d080ff1c2cef88cb74f7
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list