Change in vdsm[master]: qemuimg: add support for convert progress
nsoffer at redhat.com
nsoffer at redhat.com
Sat Jan 17 00:47:42 UTC 2015
Nir Soffer has posted comments on this change.
Change subject: qemuimg: add support for convert progress
......................................................................
Patch Set 3:
(2 comments)
http://gerrit.ovirt.org/#/c/33910/3/lib/vdsm/qemuimg.py
File lib/vdsm/qemuimg.py:
Line 257: raise QImgError(returncode, "", self.stderr)
Line 258:
Line 259: return self._command.returncode
Line 260:
Line 261: def terminate(self):
If I understand correctly Dan concern about a race - we can check here the process status before terminating:
if self._command.poll() is None:
self._command.terminate()
Line 262: self._command.terminate()
Line 263:
Line 264: def kill(self):
Line 265: self._command.kill()
Line 260:
Line 261: def terminate(self):
Line 262: self._command.terminate()
Line 263:
Line 264: def kill(self):
Same as terminate.
Line 265: self._command.kill()
Line 266:
Line 267:
Line 268: def resize(image, newSize, format=None):
--
To view, visit http://gerrit.ovirt.org/33910
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id0b53e418c62bb2e91444ba5f351c916ca417299
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list