Change in vdsm[master]: store-net-config: persist ifcfg mgmt on node

fabiand at redhat.com fabiand at redhat.com
Fri Jan 16 22:50:41 UTC 2015


Fabian Deutsch has posted comments on this change.

Change subject: store-net-config: persist ifcfg mgmt on node
......................................................................


Patch Set 1: -Code-Review

(2 comments)

http://gerrit.ovirt.org/#/c/36985/1/vdsm/vdsm-store-net-config.in
File vdsm/vdsm-store-net-config.in:

Line 16: 
Line 17: PERSISTENCE=$1
Line 18: 
Line 19: ifcfg_node_persist() {
Line 20:     for f in "$NET_CONF_BACK_DIR"/*;
> $f it will be /var/lib/vdsm/netconfback/* and will execute the continue sta
Yes, if netconfback is empty, then nothing will be persisted.
Line 21:     do
Line 22:         [ ! -f "$f" ] && continue
Line 23:         bf=`basename "$f"`
Line 24:         if [ -f "$NET_CONF_DIR/$bf" ];


Line 48:     # https://bugzilla.redhat.com/show_bug.cgi?id=1165203
Line 49:     #
Line 50:     # TODO: remove when network restoration is splitted out of vdsmd
Line 51:     # http://gerrit.ovirt.org/29441/
Line 52:     ifcfg_node_persist
> still don't get persisted.
See my comment above. But yes, we need to make sure that all files get persisted initially, so we can not look in the backup directory.
Line 53: }
Line 54: 
Line 55: unified_nonnode_persist() {
Line 56:     # Atomic directory copy by using the atomicity of overwriting a link


-- 
To view, visit http://gerrit.ovirt.org/36985
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia61b2385ce0bf44a67f627caf5b73b68992349fd
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <celebdor at gmail.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list