Change in vdsm[master]: test: Move assertXMLEqual to testlib [1/4]

danken at redhat.com danken at redhat.com
Fri Jan 16 15:39:10 UTC 2015


Dan Kenigsberg has submitted this change and it was merged.

Change subject: test: Move assertXMLEqual to testlib [1/4]
......................................................................


test: Move assertXMLEqual to testlib [1/4]

assertXMLEqual should be part of testlib, so we can use it in other
tests easily. To do that, we need to:

1. Remove unused assertXMLNone
2. Remove the dependency on xml.dom.minidom
3. Separate finding xml fragment from asserting
4. Move assertXMLEqual up to testlib.VdsmTestcase

This pach removes the unused assertXMLNone method.

Change-Id: I400848ae6c1dad6dc92a1bb71477a619802f317e
Signed-off-by: Nir Soffer <nsoffer at redhat.com>
Reviewed-on: http://gerrit.ovirt.org/36981
Reviewed-by: Francesco Romani <fromani at redhat.com>
Reviewed-by: Dan Kenigsberg <danken at redhat.com>
---
M tests/vmTests.py
1 file changed, 0 insertions(+), 5 deletions(-)

Approvals:
  Nir Soffer: Verified
  Dan Kenigsberg: Looks good to me, approved
  Francesco Romani: Looks good to me, but someone else must approve



-- 
To view, visit http://gerrit.ovirt.org/36981
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I400848ae6c1dad6dc92a1bb71477a619802f317e
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list