Change in vdsm[master]: tests: Move assertXMLEqual to testlib [2/4]
fromani at redhat.com
fromani at redhat.com
Fri Jan 16 15:35:44 UTC 2015
Francesco Romani has posted comments on this change.
Change subject: tests: Move assertXMLEqual to testlib [2/4]
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
http://gerrit.ovirt.org/#/c/36982/1/tests/vmTests.py
File tests/vmTests.py:
Line 175: <devices/>
Line 176: </domain>"""
Line 177:
Line 178: domxml = vmxml.Domain(self.conf, self.log, caps.Architecture.X86_64)
Line 179: self.assertXMLEqual(domxml.dom.toxml(), expectedXML)
> domxml.toxml returns Docuemnt XML, and we are testing here Element XML.
probably better to address this in a separate patch.
I can live with the ugly "domxml.dom" for some more time.
Line 180:
Line 181: def testOSXMLBootMenu(self):
Line 182: vmConfs = (
Line 183: # trivial cases first
--
To view, visit http://gerrit.ovirt.org/36982
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iba663bde638d9309237e21f00b85159cbc123d2b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list