Change in vdsm[master]: netlink: event monitor

danken at redhat.com danken at redhat.com
Fri Jan 16 14:53:29 UTC 2015


Dan Kenigsberg has posted comments on this change.

Change subject: netlink: event monitor
......................................................................


Patch Set 27: Code-Review-1

(1 comment)

nit

http://gerrit.ovirt.org/#/c/36197/27/tests/netlinkTests.py
File tests/netlinkTests.py:

Line 38: 
Line 39:         with _timed_monitor(1) as mon:
Line 40:             add_device_thread.start()
Line 41:             for event in mon:
Line 42:                 print event
why print?
Line 43:                 if event.get('name') == dummy_name:
Line 44:                     break
Line 45:             add_device_thread.join()
Line 46: 


-- 
To view, visit http://gerrit.ovirt.org/36197
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0f4fcfde87ad51eb832f54862371b4da1281826e
Gerrit-PatchSet: 27
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <toni at midokura.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list