Change in vdsm[master]: utils: move nice ionice sid and sudo out of execCmd

Federico Simoncelli fsimonce at redhat.com
Fri Jan 16 14:08:21 UTC 2015


Federico Simoncelli has posted comments on this change.

Change subject: utils: move nice ionice sid and sudo out of execCmd
......................................................................


Patch Set 4:

(2 comments)

http://gerrit.ovirt.org/#/c/33691/4//COMMIT_MSG
Commit Message:

Line 6: 
Line 7: utils: move nice ionice sid and sudo out of execCmd
Line 8: 
Line 9: Utility commands as nice, ionice, setsid and sudo should be reusable
Line 10: with regular Popen calls. In order to make them composable this patch
> Popen -> Popen/Cpopen 
What we need to cite here is the widely known interface (not the optimized implementation we use).
Line 11: moves them out of execCmd.
Line 12: 
Line 13: Change-Id: I442c64e8b9cfb3933dbe9879b1d442d0e96fbe40


http://gerrit.ovirt.org/#/c/33691/4/lib/vdsm/Makefile.am
File lib/vdsm/Makefile.am:

Line 22: SUBDIRS=netlink tool infra
Line 23: 
Line 24: dist_vdsmpylib_PYTHON = \
Line 25: 	__init__.py \
Line 26: 	cmdutils.py \
> I hope we can get a name without "utils" :-)
commands.py it's too generic.
Line 27: 	compat.py \
Line 28: 	define.py \
Line 29: 	exception.py \
Line 30: 	ipwrapper.py \


-- 
To view, visit http://gerrit.ovirt.org/33691
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I442c64e8b9cfb3933dbe9879b1d442d0e96fbe40
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Dima Kuznetsov <dkuznets at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Yoav Kleinberger <ykleinbe at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list