Change in vdsm[master]: qemu-img convert: check/use "-T src_cache" option when avail...

Federico Simoncelli fsimonce at redhat.com
Thu Jan 15 23:17:20 UTC 2015


Federico Simoncelli has posted comments on this change.

Change subject: qemu-img convert: check/use "-T src_cache" option when available
......................................................................


Patch Set 8:

(1 comment)

http://gerrit.ovirt.org/#/c/36308/8/lib/vdsm/qemuimg.py
File lib/vdsm/qemuimg.py:

Line 166:     options = []
Line 167:     cwdPath = None
Line 168: 
Line 169:     if _supports_src_cache('convert'):
Line 170:         cmd.extend(("-T", "none"))
In a previous review I mentioned that we needed the same for rebase. Have I missed a reply on that?
Line 171: 
Line 172:     if srcFormat:
Line 173:         cmd.extend(("-f", srcFormat))
Line 174: 


-- 
To view, visit http://gerrit.ovirt.org/36308
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6e07f182e880f79055e53ef47aa28ddcf9659c45
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Amador Pahim <apahim at redhat.com>
Gerrit-Reviewer: Amador Pahim <apahim at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list