Change in vdsm[master]: testSetupNetworksAddDelDhcp: Delete a lease file left over b...

osvoboda at redhat.com osvoboda at redhat.com
Thu Jan 15 21:49:40 UTC 2015


Ondřej Svoboda has posted comments on this change.

Change subject: testSetupNetworksAddDelDhcp: Delete a lease file left over by dhclient
......................................................................


Patch Set 2:

(1 comment)

Too much whitespace, but otherwise no unnecessary complexity (if I chose to extend vethIf).

http://gerrit.ovirt.org/#/c/36974/2/tests/functional/networkTests.py
File tests/functional/networkTests.py:

Line 1728:     @RequireVethMod
Line 1729:     def testSetupNetworksAddDelDhcp(self, bridged):
Line 1730:         el6 = _system_is_el6()
Line 1731: 
Line 1732:         with vethIf() as (left, right):
I could merge the context managers somehow, but this solution is cleaner, except the amount of whitespace (and line wrapping) needed.
Line 1733:             with delete_dhclient_leases(NETWORK_NAME if bridged else right):
Line 1734:                 veth.setIP(left, IP_ADDRESS, IP_CIDR)
Line 1735:                 veth.setIP(left, IPv6_ADDRESS, IPv6_CIDR, 6)
Line 1736:                 veth.setLinkUp(left)


-- 
To view, visit http://gerrit.ovirt.org/36974
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1af7c7acc3fcb6526da1e12f8b5fe82e8415536b
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list