Change in vdsm[master]: netinfo: Split a DHCPv4-specific portion from a branch in _p...

danken at redhat.com danken at redhat.com
Thu Jan 15 15:20:45 UTC 2015


Dan Kenigsberg has posted comments on this change.

Change subject: netinfo: Split a DHCPv4-specific portion from a branch in _parse_lease_file
......................................................................


Patch Set 3: Code-Review+2

(1 comment)

http://gerrit.ovirt.org/#/c/36836/3/lib/vdsm/netinfo.py
File lib/vdsm/netinfo.py:

Line 526
Line 527
Line 528
Line 529
Line 530
I find

  elif family == 4 and line.startswith(EXPIRE):

more readable.


-- 
To view, visit http://gerrit.ovirt.org/36836
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia3367746310364be78be69b8c59528c2144f19d9
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list