Change in vdsm[master]: vm: cleaner retrieval of graphics stats

fromani at redhat.com fromani at redhat.com
Thu Jan 15 08:41:27 UTC 2015


Francesco Romani has posted comments on this change.

Change subject: vm: cleaner retrieval of graphics stats
......................................................................


Patch Set 3:

(2 comments)

http://gerrit.ovirt.org/#/c/36791/3//COMMIT_MSG
Commit Message:

Line 3: AuthorDate: 2015-01-12 10:46:37 +0100
Line 4: Commit:     Francesco Romani <fromani at redhat.com>
Line 5: CommitDate: 2015-01-14 14:05:16 +0100
Line 6: 
Line 7: vm: faster retrieval of graphics stats
> In a comment to the reviewed you placed some hard data stating that the imp
You are of course right. Done
Even thought, it is actually faster in microbenchmarks :)
Line 8: 
Line 9: Device object and device configuration
Line 10: data is kept in sync, so there is no need to scan all the
Line 11: device configuration data to report it to Engine.


Line 6: 
Line 7: vm: faster retrieval of graphics stats
Line 8: 
Line 9: Device object and device configuration
Line 10: data is kept in sync, so there is no need to scan all the
> I'm not into data-datum nagging! but in this case we have two sets of data 
Fixed. And, by the way, this kind of nitpicking is always welcome (in the end, hopefully, I'll learn).
Line 11: device configuration data to report it to Engine.
Line 12: 
Line 13: Instead, just iterate on the Graphics Device classes.
Line 14: 


-- 
To view, visit http://gerrit.ovirt.org/36791
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I337e2baa5a349c2e750f883c4ca697aaafc55bf3
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list