Change in vdsm[master]: virt: faster getVMList

fromani at redhat.com fromani at redhat.com
Wed Jan 14 13:10:00 UTC 2015


Francesco Romani has posted comments on this change.

Change subject: virt: faster getVMList
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.ovirt.org/#/c/35139/1/vdsm/virt/vm.py
File vdsm/virt/vm.py:

Line 2214:         self.saveState()
Line 2215: 
Line 2216:     def status(self, fullStatus=True):
Line 2217:         if not fullStatus:
Line 2218:             return {'vmId': self.id, 'status': self.lastStatus}
> a newline after the early return would be nice.
Done
Line 2219:         # used by API.Global.getVMList
Line 2220:         self.conf['status'] = self.lastStatus
Line 2221:         with self._confLock:
Line 2222:             # Filter out any internal keys


-- 
To view, visit http://gerrit.ovirt.org/35139
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I82c602301bc133d6a4971c8a4d15f823929f7c43
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list