Change in vdsm[master]: fileUtils: Remove unneeded else block

danken at redhat.com danken at redhat.com
Tue Jan 13 18:37:50 UTC 2015


Dan Kenigsberg has submitted this change and it was merged.

Change subject: fileUtils: Remove unneeded else block
......................................................................


fileUtils: Remove unneeded else block

The code is about handling existing directories, not about taking one of
two choices. Using early return on errors and keeping the normal code
path is more clear.

Change-Id: I67f043ce6b9fac2e980d0e94ef638a5eabfc2c7a
Signed-off-by: Nir Soffer <nsoffer at redhat.com>
Reviewed-on: http://gerrit.ovirt.org/36779
Reviewed-by: Dan Kenigsberg <danken at redhat.com>
Reviewed-by: Federico Simoncelli <fsimonce at redhat.com>
---
M vdsm/storage/fileUtils.py
1 file changed, 10 insertions(+), 11 deletions(-)

Approvals:
  Nir Soffer: Verified
  Federico Simoncelli: Looks good to me, approved
  Dan Kenigsberg: Looks good to me, but someone else must approve



-- 
To view, visit http://gerrit.ovirt.org/36779
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I67f043ce6b9fac2e980d0e94ef638a5eabfc2c7a
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list