Change in vdsm[master]: netlink: event monitor
danken at redhat.com
danken at redhat.com
Tue Jan 13 10:54:28 UTC 2015
Dan Kenigsberg has posted comments on this change.
Change subject: netlink: event monitor
......................................................................
Patch Set 19:
(2 comments)
http://gerrit.ovirt.org/#/c/36197/19/tests/netlinkTests.py
File tests/netlinkTests.py:
Line 78: dummy.remove(dummy_name)
Line 79: finally:
Line 80: mon.stop()
Line 81: found = False
Line 82: conditions = [
expected_events
Line 83: {'name': dummy_name, 'type': 'dummy', 'event': 'new_link'},
Line 84: {'label': dummy_name, 'family': 'inet', 'address': IP_ADDRESS +
Line 85: '/' + IP_CIDR, 'event': 'new_addr'},
Line 86: {'oif': dummy_name, 'event': 'new_route'}]
Line 164: pass
Line 165:
Line 166:
Line 167: @contextmanager
Line 168: def _monitorTimer(monitor):
it would be nicer if a _timed_monitor(timeout) create a new monitor, and stops it when timeout expires.
Line 169: def _timeout():
Line 170: monitor.stop()
Line 171:
Line 172: timer = Timer(1, _timeout)
--
To view, visit http://gerrit.ovirt.org/36197
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0f4fcfde87ad51eb832f54862371b4da1281826e
Gerrit-PatchSet: 19
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list