Change in vdsm[master]: tool: change configure verb logic.

danken at redhat.com danken at redhat.com
Mon Jan 12 17:30:12 UTC 2015


Dan Kenigsberg has posted comments on this change.

Change subject: tool: change configure verb logic.
......................................................................


Patch Set 11: Code-Review-1

(1 comment)

http://gerrit.ovirt.org/#/c/34100/11//COMMIT_MSG
Commit Message:

Line 3: AuthorDate: 2014-10-14 01:17:22 +0300
Line 4: Commit:     Mooli Tayer <mtayer at redhat.com>
Line 5: CommitDate: 2015-01-12 18:29:57 +0200
Line 6: 
Line 7: tool: change configure verb logic.
sorry, I do not understand the changed logic. In which cases is the new configure() different  from the former implementation? Could you provide an example?

What does it mean for configure "to error"?

Can you explain the benefits of the new semantics? Your own opinion is cherished, but I please explain in more detail upon what it is based.
Line 8: 
Line 9: In the following case configure errors:
Line 10: configure(isconfigured()=NO, validate()=False, force()= False).
Line 11: 


-- 
To view, visit http://gerrit.ovirt.org/34100
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I166fbae855ebff93ef84270f11b74f32fcc115c2
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: mooli tayer <mtayer at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: mooli tayer <mtayer at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list