Change in vdsm[ovirt-3.5]: init: wait for network service

ybronhei at redhat.com ybronhei at redhat.com
Mon Jan 12 12:02:03 UTC 2015


Yaniv Bronhaim has submitted this change and it was merged.

Change subject: init: wait for network service
......................................................................


init: wait for network service

The network service is not synchronous. It returns before all of the
interfaces that it started are actually up.

This is particularly problematic when upgrading from ovirt-3.4 to
ovirt-3.5, as one of the first pre-run tasks is to upgrade network
configuration to the "unified persistence" model.

This patch waits up to 10 seconds for vdsm-controlled interfaces to
obtain their IPv4 address. It's a hack, an ugly hack, that does not solve
the inherent race. The race would be solved only when we tap into
netlink's event monitor and stall ifup until the interface is actually
up.

Change-Id: I89abe7a83673c2232f8b249f23a39e27e01e50be
Bug-Url: https://bugzilla.redhat.com/1174611
Signed-off-by: Dan Kenigsberg <danken at redhat.com>
Reviewed-on: http://gerrit.ovirt.org/36647
Reviewed-by: Ido Barkan <ibarkan at redhat.com>
Reviewed-by: Petr Horáček <phoracek at redhat.com>
Reviewed-by: Douglas Schilling Landgraf <dougsland at redhat.com>
Tested-by: Douglas Schilling Landgraf <dougsland at redhat.com>
Reviewed-on: http://gerrit.ovirt.org/36703
Reviewed-by: Yaniv Bronhaim <ybronhei at redhat.com>
---
M init/vdsmd_init_common.sh.in
1 file changed, 61 insertions(+), 0 deletions(-)

Approvals:
  Douglas Schilling Landgraf: Verified; Looks good to me, but someone else must approve
  Ido Barkan: Looks good to me, but someone else must approve
  Yaniv Bronhaim: Looks good to me, approved
  Petr Horáček: Looks good to me, but someone else must approve



-- 
To view, visit http://gerrit.ovirt.org/36703
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I89abe7a83673c2232f8b249f23a39e27e01e50be
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org


More information about the vdsm-patches mailing list