Change in vdsm[master]: Set sysctl to allow iSCSI multipath with multiple NICs in th...

Federico Simoncelli fsimonce at redhat.com
Fri Jan 9 17:51:45 UTC 2015


Federico Simoncelli has posted comments on this change.

Change subject: Set sysctl to allow iSCSI multipath with multiple NICs in the same subnet
......................................................................


Patch Set 26: Code-Review+1

(2 comments)

Minor nits but ready to be merged.

http://gerrit.ovirt.org/#/c/31529/26/vdsm/storage/iscsi.py
File vdsm/storage/iscsi.py:

Line 558: 
Line 559:     if not any(sessions) and netIfaceName != getRouteDeviceTo(hostname):
Line 560:         if loose_mode:
Line 561:             supervdsm.getProxy().set_rp_filter_loose(netIfaceName)
Line 562:             log.info("Setting loose mode rp_filter for device %r." %
Nit: "Setting" announces the execution (should preceed set_rp_filter_loose).

If you want to leave it after then it should be "Lose mode rp_filter set for device..."
Line 563:                      netIfaceName)
Line 564:         else:
Line 565:             supervdsm.getProxy().set_rp_filter_strict(netIfaceName)
Line 566:             log.info("Setting strict mode rp_filter for device %r." %


Line 562:             log.info("Setting loose mode rp_filter for device %r." %
Line 563:                      netIfaceName)
Line 564:         else:
Line 565:             supervdsm.getProxy().set_rp_filter_strict(netIfaceName)
Line 566:             log.info("Setting strict mode rp_filter for device %r." %
Same here.


-- 
To view, visit http://gerrit.ovirt.org/31529
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibf93d49317c76aece764e53e58e0ff28868f16b0
Gerrit-PatchSet: 26
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Amador Pahim <apahim at redhat.com>
Gerrit-Reviewer: Amador Pahim <apahim at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <toni at midokura.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgotliv at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Yoav Kleinberger <ykleinbe at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: jian wang <wjian84 at gmail.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list