Change in vdsm[master]: IpConfig: Require all parameters and simplify

osvoboda at redhat.com osvoboda at redhat.com
Thu Jan 8 20:51:15 UTC 2015


Ondřej Svoboda has posted comments on this change.

Change subject: IpConfig: Require all parameters and simplify
......................................................................


Patch Set 2: Verified-1 Code-Review-1

(1 comment)

I was too eager on the namedtuple.

http://gerrit.ovirt.org/#/c/36712/2/vdsm/network/models.py
File vdsm/network/models.py:

Line 48:         raise NotImplementedError
Line 49: 
Line 50:     @property
Line 51:     def ipConfig(self):
Line 52:         return self.ip.getConfig()
Not yet ;-)
Line 53: 
Line 54:     @property
Line 55:     def bridge(self):
Line 56:         if isinstance(self.master, Bridge):


-- 
To view, visit http://gerrit.ovirt.org/36712
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I09a5d1e3468004f529c2bc9708cff2243c16241a
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <toni at midokura.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list