Change in vdsm[master]: multipath configurator: reload only if service is active

danken at redhat.com danken at redhat.com
Thu Jan 8 15:34:25 UTC 2015


Dan Kenigsberg has posted comments on this change.

Change subject: multipath configurator: reload only if service is active
......................................................................


Patch Set 5:

(1 comment)

http://gerrit.ovirt.org/#/c/36387/5/lib/vdsm/tool/configurators/multipath.py
File lib/vdsm/tool/configurators/multipath.py:

Line 144
Line 145
Line 146
Line 147
Line 148
Assume this failed because the service was down.

Then in line 150 we find out that the service is indeed down, and we report no error. I see no problem in the current code.


-- 
To view, visit http://gerrit.ovirt.org/36387
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie1e8eceaaa486f05b1ea4f1733df669b2a44682a
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list