Change in vdsm[master]: Simplify tests for qemuimg to allow additional capabilities ...

nsoffer at redhat.com nsoffer at redhat.com
Thu Jan 8 14:45:30 UTC 2015


Nir Soffer has posted comments on this change.

Change subject: Simplify tests for qemuimg to allow additional capabilities checks
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.ovirt.org/#/c/36366/3/tests/qemuimgTests.py
File tests/qemuimgTests.py:

Line 248:     def supported(self, command, result):
Line 249:         def check(arg):
Line 250:             self.assertEqual(command, arg)
Line 251:             return result
Line 252:         return check
> But extract to a class and run an assertEqual() in that class means the ext
Extending TestCaseBase will be the simplest solution.
Line 253: 
Line 254: 
Line 255: class CompatTests(TestCaseBase):
Line 256: 


-- 
To view, visit http://gerrit.ovirt.org/36366
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I386772bf2a25a880b5ad387f284679eed81c5615
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Amador Pahim <apahim at redhat.com>
Gerrit-Reviewer: Amador Pahim <apahim at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list