Change in vdsm[master]: netinfo: Make bootproto4 a boolean and rename it while it is...

ibarkan at redhat.com ibarkan at redhat.com
Thu Jan 8 12:58:26 UTC 2015


Ido Barkan has posted comments on this change.

Change subject: netinfo: Make bootproto4 a boolean and rename it while it is still unused
......................................................................


Patch Set 10: Code-Review+1

(1 comment)

http://gerrit.ovirt.org/#/c/35984/10/tests/functional/networkTests.py
File tests/functional/networkTests.py:

Line 1708:         with vethIf() as (left, right):
Line 1709:             veth.setIP(left, IP_ADDRESS, IP_CIDR)
Line 1710:             veth.setLinkUp(left)
Line 1711:             with dnsmasqDhcp(left):
Line 1712:                 dhcpv4 = True
> I think it is OK to keep it like that, as it seizes to be a constant in a f
agreed
Line 1713:                 bootproto = 'dhcp'
Line 1714:                 network = {NETWORK_NAME: {'nic': right, 'bridged': bridged,
Line 1715:                                           'bootproto': bootproto,
Line 1716:                                           'blockingdhcp': True}}


-- 
To view, visit http://gerrit.ovirt.org/35984
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I29abc8db77f2ab12188d6007f072e16ccfd4b223
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia at redhat.com>
Gerrit-Reviewer: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list