Change in vdsm[master]: contrib: add useful shell functions to assist in vdsm develo...

phoracek at redhat.com phoracek at redhat.com
Thu Jan 8 12:40:01 UTC 2015


Petr Horáček has posted comments on this change.

Change subject: contrib: add useful shell functions to assist in vdsm development
......................................................................


Patch Set 7: Code-Review-1

(1 comment)

http://gerrit.ovirt.org/#/c/36344/7/contrib/shell_helper
File contrib/shell_helper:

Line 83: }
Line 84: 
Line 85: vdsm_build() {
Line 86:     pushd $VDSM_DIR
Line 87:     ./autogen.sh --system && ./configure && NOSE_EXCLUDE=.* make rpm
we need make too to handle *.in files, like run_tests*

./autogen.sh --system && ./configure && make && NOSE_EXCLUDE=.* make rpm
Line 88:     popd
Line 89: }
Line 90: 
Line 91: vdsm_build_with_hooks() {


-- 
To view, visit http://gerrit.ovirt.org/36344
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ide4131db838640a5836fd029696849bced267308
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon <toni at midokura.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <toni at midokura.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list