Change in vdsm[master]: fileSD: Optimize getAllVolumes on file storage

nsoffer at redhat.com nsoffer at redhat.com
Wed Jan 7 23:35:34 UTC 2015


Nir Soffer has posted comments on this change.

Change subject: fileSD: Optimize getAllVolumes on file storage
......................................................................


Patch Set 2:

(2 comments)

http://gerrit.ovirt.org/#/c/36593/2/vdsm/storage/fileSD.py
File vdsm/storage/fileSD.py:

Line 408:     def getAllVolumes(self):
Line 409:         """
Line 410:         Return dict {volUUID: ((imgUUIDs,), parentUUID)} of the domain.
Line 411: 
Line 412:         Template self image is the first item in template volume images tuple.
> The text of the docstring is still illegible. Consider something like:
Thanks, this is better.
Line 413:         The parent uuid is available only for template volumes.
Line 414: 
Line 415:         Setting parent = None for compatibility with block version.
Line 416:         """


Line 409:         """
Line 410:         Return dict {volUUID: ((imgUUIDs,), parentUUID)} of the domain.
Line 411: 
Line 412:         Template self image is the first item in template volume images tuple.
Line 413:         The parent uuid is available only for template volumes.
> Templates have not parent.
I think that Dan suggested text make this clear.
Line 414: 
Line 415:         Setting parent = None for compatibility with block version.
Line 416:         """
Line 417:         volMetaPattern = os.path.join(self.mountpoint, self.sdUUID,


-- 
To view, visit http://gerrit.ovirt.org/36593
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idc19ce272b7e0b9c91d2f90aa46b5ddd21d69ece
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at gmail.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list