Change in vdsm[master]: virt: Optimize guest agent string filtering

nsoffer at redhat.com nsoffer at redhat.com
Wed Jan 7 22:49:28 UTC 2015


Nir Soffer has posted comments on this change.

Change subject: virt: Optimize guest agent string filtering
......................................................................


Patch Set 4:

(1 comment)

http://gerrit.ovirt.org/#/c/36630/4/vdsm/virt/guestagent.py
File vdsm/virt/guestagent.py:

Line 89:     """
Line 90:     def __init__(self, *args, **kwargs):
Line 91:         print "Woot init"
Line 92:         json.JSONDecoder.__init__(self, *args, **kwargs)
Line 93:         self._old_parse_string = self.parse_string
This line fail with this exception on host06-rack04:

 handle_events-72::ERROR::2015-01-07 22:01:01,920::vmchannels::72::vds::(_handle_event) Exception on read callback.
 Traceback (most recent call last):
  File "/usr/share/vdsm/virt/vmchannels.py", line 67, in _handle_event
    if obj['read_cb'](obj['opaque']):
  File "/usr/share/vdsm/virt/guestagent.py", line 472, in _onChannelRead
    self._handleData(data)
  File "/usr/share/vdsm/virt/guestagent.py", line 447, in _handleData
    self._processMessage(line)
  File "/usr/share/vdsm/virt/guestagent.py", line 431, in _processMessage
    (message, args) = self._parseLine(line)
  File "/usr/share/vdsm/virt/guestagent.py", line 483, in _parseLine
    args = json.loads(uniline, cls=FilteringJSONDecoder)
  File "/usr/lib64/python2.6/json/__init__.py", line 318, in loads
    return cls(encoding=encoding, **kw).decode(s)
  File "/usr/share/vdsm/virt/guestagent.py", line 92, in __init__
    self._old_parse_string = self.parse_string
 AttributeError: 'FilteringJSONDecoder' object has no attribute 'parse_string'
Line 94:         self.parse_string = self._wrap_parse_string
Line 95:         self.scan_once = json.scanner.py_make_scanner(self)
Line 96: 
Line 97:     def _wrap_parse_string(self, *args, **kwargs):


-- 
To view, visit http://gerrit.ovirt.org/36630
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ief8da73dc180212b594937e658ae8f5f57c63bac
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <mskrivan at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list