Change in vdsm[master]: ip route: parse route flags

danken at redhat.com danken at redhat.com
Wed Jan 7 15:20:15 UTC 2015


Dan Kenigsberg has submitted this change and it was merged.

Change subject: ip route: parse route flags
......................................................................


ip route: parse route flags

Previously, routes like

    unreachable ::ffff:0.0.0.0/96 dev lo  metric 1024  error -101
    broadcast 240.0.0.255 dev veth_23  table local  proto kernel  scope link  src 240.0.0.1

(the latter occuring natually in kernel's "local" routing table)
would just spew warnings in source routing tests. This is because we
parse routes from all routing tables, not just for interfaces we manage,
to avoid calling iproute2 multiple times.

Change-Id: Ia0a882aa1b57dc0c7b26095205b884ae9eff0173
Signed-off-by: Dan Kenigsberg <danken at redhat.com>
Reviewed-on: http://gerrit.ovirt.org/35971
Reviewed-by: Ondřej Svoboda <osvoboda at redhat.com>
Reviewed-by: Petr Horáček <phoracek at redhat.com>
Reviewed-by: Antoni Segura Puimedon <toni at midokura.com>
Tested-by: Ondřej Svoboda <osvoboda at redhat.com>
---
M lib/vdsm/ipwrapper.py
M tests/ipwrapperTests.py
2 files changed, 30 insertions(+), 7 deletions(-)

Approvals:
  Ondřej Svoboda: Verified; Looks good to me, but someone else must approve
  Antoni Segura Puimedon: Looks good to me, but someone else must approve
  Petr Horáček: Looks good to me, but someone else must approve
  Dan Kenigsberg: Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/35971
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ia0a882aa1b57dc0c7b26095205b884ae9eff0173
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <celebdor at gmail.com>
Gerrit-Reviewer: Antoni Segura Puimedon <toni at midokura.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list