Change in vdsm[master]: ip route: parse only first part of each route

osvoboda at redhat.com osvoboda at redhat.com
Wed Jan 7 15:17:51 UTC 2015


Ondřej Svoboda has posted comments on this change.

Change subject: ip route: parse only first part of each route
......................................................................


Patch Set 4: Verified+1 Code-Review+1

In the same manual verification as for the previous patch I have not seen any ValueError, all routes we come across are now accepted by the parser. The logs don't show parser warnings anymore.

In iproute2 code I checked that we don't lose much when skipping the second lines (and I plan to phase out ipwrapper in the future, in favor of libnl).

-- 
To view, visit http://gerrit.ovirt.org/36184
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5b655ddbbb2fdaa7ec57bc460bc593e40bac977e
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No


More information about the vdsm-patches mailing list