Change in vdsm[master]: numa: virt: optimize vpcu pid lookup

bazulay at redhat.com bazulay at redhat.com
Wed Jan 7 10:07:34 UTC 2015


Barak Azulay has posted comments on this change.

Change subject: numa: virt: optimize vpcu pid lookup
......................................................................


Patch Set 2: Code-Review-1

(1 comment)

I know this is a workaround ... but this is not good enough

http://gerrit.ovirt.org/#/c/36626/2/vdsm/numaUtils.py
File vdsm/numaUtils.py:

Line 24: import supervdsm
Line 25: 
Line 26: 
Line 27: def getVcpuPid(vmName):
Line 28:     runInfo = ET.parse("/var/run/libvirt/qemu/%s.xml" % vmName)
I do not understand why is this always being read from file system , it should be (or worst ... already is cached).
Line 29:     vCpuPids = {}
Line 30:     for vCpuIndex, vCpu in enumerate(runInfo.findall('./vcpus/vcpu[@pid]')):
Line 31:         vCpuPids[vCpuIndex] = vCpu.get('pid')
Line 32:     return vCpuPids


-- 
To view, visit http://gerrit.ovirt.org/36626
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ice97563fc11be79cc3215db434761024b3e244dc
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: Vitor de Lima <vdelima at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list