Change in vdsm[master]: API: move diskSizeExtend logic from BindingXMLRPC

nsoffer at redhat.com nsoffer at redhat.com
Tue Jan 6 13:32:27 UTC 2015


Nir Soffer has posted comments on this change.

Change subject: API: move diskSizeExtend logic from BindingXMLRPC
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.ovirt.org/#/c/36590/2/vdsm/API.py
File vdsm/API.py:

Line 589:             return errCode['noVM']
Line 590:         return v.diskReplicateFinish(srcDisk, dstDisk)
Line 591: 
Line 592:     def diskSizeExtend(self, driveSpecs, newSize):
Line 593:         if self._UUID == VM.BLANK_UUID:
> This logic doesn't belong to the VM object.
This API is already in the vm object, and we cannot change this api due to backward compatibility, so VM.diskSizeExtend must handle this request.

We don't have a better place to put the logic, and it does make sense that a vm handles a disk resize request, and it does not matter if the vm is up or down.
Line 594:             try:
Line 595:                 volume = Volume(
Line 596:                     driveSpecs['volumeID'], driveSpecs['poolID'],
Line 597:                     driveSpecs['domainID'], driveSpecs['imageID'])


-- 
To view, visit http://gerrit.ovirt.org/36590
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9014154f376609d8bd547b7c008954981785b551
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list