Change in vdsm[master]: fixed a key error in _delNetwork

danken at redhat.com danken at redhat.com
Tue Jan 6 12:12:27 UTC 2015


Dan Kenigsberg has posted comments on this change.

Change subject: fixed a key error in _delNetwork
......................................................................


Patch Set 1: Code-Review-1

(3 comments)

http://gerrit.ovirt.org/#/c/36598/1//COMMIT_MSG
Commit Message:

Line 5: CommitDate: 2015-01-06 08:29:34 +0200
Line 6: 
Line 7: fixed a key error in _delNetwork
Line 8: 
Line 9: When _delNetwork was called from _delBrokenNetwork it's netinfo
it's -> its
Line 10: is adapted so it would be able to remove the broken netwrok.
Line 11: This fixes a missing key in the broken network description
Line 12: dictionary.
Line 13: 


Line 7: fixed a key error in _delNetwork
Line 8: 
Line 9: When _delNetwork was called from _delBrokenNetwork it's netinfo
Line 10: is adapted so it would be able to remove the broken netwrok.
Line 11: This fixes a missing key in the broken network description
without a backtrace, this message is a bit cryptic.

Without this patch, trying to remove a broken bridgeless network fails with a KeyError due to a missing bootproto element.

This was introduced by commit XXXXX and should/shouldnot be backported to the stable branch.
Line 12: dictionary.
Line 13: 
Line 14: Change-Id: I09d32946cf2667b1888b1d84d0eab2d7118a42b0


http://gerrit.ovirt.org/#/c/36598/1/tests/functional/networkTests.py
File tests/functional/networkTests.py:

Line 1824:                                                       NOCHK)
Line 1825:             self.assertEqual(status, SUCCESS, msg)
Line 1826:             self.assertNetworkDoesntExist(NETWORK_NAME)
Line 1827: 
Line 1828:     def testBrokenBridgedNetwork(self):
The code seems practically the same as of testBrokenBridgelessNetReplacement. How about adding a bridged=True argument to the test and using permuatations?
Line 1829:         with dummyIf(1) as (nic,):
Line 1830:             network = {NETWORK_NAME: {'nic': nic, 'vlan': VLAN_ID,
Line 1831:                                       'bridged': True}}
Line 1832:             status, msg = self.vdsm_net.setupNetworks(network, {}, NOCHK)


-- 
To view, visit http://gerrit.ovirt.org/36598
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I09d32946cf2667b1888b1d84d0eab2d7118a42b0
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list