Change in vdsm[master]: storageServer: drop unnecessary list comprehension

nsoffer at redhat.com nsoffer at redhat.com
Tue Jan 6 10:39:26 UTC 2015


Nir Soffer has posted comments on this change.

Change subject: storageServer: drop unnecessary list comprehension
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

http://gerrit.ovirt.org/#/c/36592/1/vdsm/storage/storageServer.py
File vdsm/storage/storageServer.py:

Line 423:             else:
Line 424:                 self._lastSessionId = session.id
Line 425:                 return session
Line 426: 
Line 427:         self.log.debug("Session mismatches: %s", errors)
> Formatting only when needed is nice, but do you get good enough output?
This formats:

    [Mismatch(), Mismatch()]

Instead of:

    ["error ...", "error ..."]

Which is more useful.

I think this is solved better in http://gerrit.ovirt.org/36606
Line 428:         raise OSError(errno.ENOENT, "Session not found")
Line 429: 
Line 430:     def isConnected(self):
Line 431:         try:


-- 
To view, visit http://gerrit.ovirt.org/36592
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4459f2cf3fb51fc7eaa466be36198b3b46711628
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list