Change in vdsm[master]: Enable autotools and run check depends rhev_build or fedora_...

ybronhei at redhat.com ybronhei at redhat.com
Mon Jan 5 13:27:18 UTC 2015


Yaniv Bronhaim has posted comments on this change.

Change subject: Enable autotools and run check depends rhev_build or fedora_koji_build
......................................................................


Patch Set 1:

(2 comments)

http://gerrit.ovirt.org/#/c/36417/1/vdsm.spec.in
File vdsm.spec.in:

Line 21: %global rhev_build_config_opt     --enable-rhev
Line 22: %endif
Line 23: 
Line 24: 
Line 25: %if 0%{rhev_build} || 0%{fedora_koji_build}
> As far as I recall, neither rhev nor fedora koji currently touch configure.
don't know. its only if we wouldn't cancel the "make check" part I guess. not sure it still necessary . happy to get your intervention in how we modify the spec each build. I also wondered why we need it for very long time and except "copy it from previous build because that how it was and we don't want to touch it" I haven't got better reply.
Line 26: %{!?enable_autotools:%define enable_autotools 1}
Line 27: %else
Line 28: # Default to skipping autoreconf.  Distros can change just this one line
Line 29: # (or provide a command-line override) if they backport any patches that


Line 31: %{!?enable_autotools:%define enable_autotools 0}
Line 32: %endif
Line 33: 
Line 34: # Skips check since rhel default repos lack pep8 and pyflakes
Line 35: %if ! 0%{?rhel} && ! 0%{?rhev_build} && ! 0%{fedora_koji_build}
> Are you sure? if it is a fedora_koji_build for epel6, we do NOT want with_c
we want with_check only for manual build , and not for rhel. therefore it needs to be not rhel, not koji, and not rhev for check
Line 36: %{!?with_check:%global with_check 1}
Line 37: %else
Line 38: %{!?with_check:%global with_check 0}
Line 39: %endif


-- 
To view, visit http://gerrit.ovirt.org/36417
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibcd6bca40897db76f1461e2f84600efa8b8532ce
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list