Change in vdsm[master]: lib: add support for utillinux commands

danken at redhat.com danken at redhat.com
Fri Jan 2 19:19:52 UTC 2015


Dan Kenigsberg has posted comments on this change.

Change subject: lib: add support for utillinux commands
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.ovirt.org/#/c/35629/3//COMMIT_MSG
Commit Message:

Line 3: AuthorDate: 2014-11-19 10:48:40 +0000
Line 4: Commit:     Federico Simoncelli <fsimonce at redhat.com>
Line 5: CommitDate: 2014-11-27 23:40:36 +0000
Line 6: 
Line 7: lib: add support for utillinux commands
may I ask why we'd like this level of assortment? I mean, the utils in utillinux do not seem related to each other very much; we already have "binding" to few (mount, fstab). So I prefer a standalone binding for blkdiscard.
Line 8: 
Line 9: Change-Id: I2ea7dd19fadc600b8fe78fb436ae430d35f52165


-- 
To view, visit http://gerrit.ovirt.org/35629
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2ea7dd19fadc600b8fe78fb436ae430d35f52165
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list