Change in vdsm[master]: tool: autoload modules.

mtayer at redhat.com mtayer at redhat.com
Thu Jan 1 09:40:26 UTC 2015


mooli tayer has posted comments on this change.

Change subject: tool: autoload modules.
......................................................................


Patch Set 9:

(2 comments)

http://gerrit.ovirt.org/#/c/34049/9//COMMIT_MSG
Commit Message:

Line 3: AuthorDate: 2014-10-12 01:04:03 +0300
Line 4: Commit:     Mooli Tayer <mtayer at redhat.com>
Line 5: CommitDate: 2014-12-25 14:25:59 +0200
Line 6: 
Line 7: tool: autoload modules.
> just mention here that you also arrange imports
I would rather add above the changed import:
 # todo: remove hack, needed for autoload

what say u?

I will also try again to understand why it happens..
Line 8: 
Line 9: Change-Id: I6cc14a1c409ee607e18d42adcd8a54759d8dbf6d


http://gerrit.ovirt.org/#/c/34049/9/lib/vdsm/tool/configurator.py
File lib/vdsm/tool/configurator.py:

Line 274:     return sortedModules
Line 275: 
Line 276: 
Line 277: def _parse_args(action, *args):
Line 278:     _load_configurators()
> I would take it globally , on module import
It is not global intentionally:

"Saggi Mizrahi
 Nov 9 3:54 PM
 I'd prefer if this was lazy loaded since it's a lot of work
 to do during import."

what I can do is move _load_configurators out of parse args,
and replace each
 _parse_args() 
 with:
 _load_configurators
 _parse_args()

Do you prefer?
Line 279:     parser = argparse.ArgumentParser('vdsm-tool %s' % (action))
Line 280:     parser.add_argument(
Line 281:         '--module',
Line 282:         dest='modules',


-- 
To view, visit http://gerrit.ovirt.org/34049
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6cc14a1c409ee607e18d42adcd8a54759d8dbf6d
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: mooli tayer <mtayer at redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Dima Kuznetsov <dkuznets at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: mooli tayer <mtayer at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list