Change in vdsm[master]: gluster: volume snapshot config list and set verbs.

piotr.kliczewski at gmail.com piotr.kliczewski at gmail.com
Fri Feb 20 09:33:43 UTC 2015


Piotr Kliczewski has posted comments on this change.

Change subject: gluster: volume snapshot config list and set verbs.
......................................................................


Patch Set 10:

(1 comment)

http://gerrit.ovirt.org/#/c/34741/10/vdsm/rpc/vdsmapi-gluster-schema.json
File vdsm/rpc/vdsmapi-gluster-schema.json:

Line 1827: #
Line 1828: # @optionValue:  Value of the configration option
Line 1829: #
Line 1830: # Returns:
Line 1831: # success/failure
> We raise exceptions in failure case, these exceptions have errCode and mess
I can see that you rise again GlusterSnapshotConfigGetFailedException so it is sent as error response. Do we still need to have success/failure here? It seems to be redundant.
Line 1832: #
Line 1833: # Since: 4.17.0
Line 1834: ##
Line 1835: {'command': {'class': 'GlusterSnapshot', 'name': 'configSet'},


-- 
To view, visit http://gerrit.ovirt.org/34741
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iee32a95cf028cda33f25776c08820c5ed80f1033
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Darshan N <dnarayan at redhat.com>
Gerrit-Reviewer: Bala.FA <barumuga at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Darshan N <dnarayan at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Shubhendu Tripathi <shtripat at redhat.com>
Gerrit-Reviewer: Timothy Asir <tjeyasin at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list