Change in vdsm[master]: gluster: add createBrick verb

piotr.kliczewski at gmail.com piotr.kliczewski at gmail.com
Wed Feb 18 12:28:58 UTC 2015


Piotr Kliczewski has posted comments on this change.

Change subject: gluster: add createBrick verb
......................................................................


Patch Set 20: Code-Review-1

(1 comment)

http://gerrit.ovirt.org/#/c/35498/20/vdsm/rpc/vdsmapi-gluster-schema.json
File vdsm/rpc/vdsmapi-gluster-schema.json:

Line 1260: # @RaidDevice:
Line 1261: #
Line 1262: # Raid storage devices.
Line 1263: #
Line 1264: # @type :       # Raid type
Please check whether parameters in this type are optional or not?

We use # at the beginning of description for optional parameters only.

For optional please add optional word after # and update data structure with * or remove # from the description.
Line 1265: #
Line 1266: # @stripeSize:  # Stripe size
Line 1267: #
Line 1268: # @diskCnt:     # Disk count


-- 
To view, visit http://gerrit.ovirt.org/35498
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic47c4c56834deb457ae9d038f77bcf69c7b39ba5
Gerrit-PatchSet: 20
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Timothy Asir <tjeyasin at redhat.com>
Gerrit-Reviewer: Bala.FA <barumuga at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Darshan N <dnarayan at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Sahina Bose <sabose at redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo at redhat.com>
Gerrit-Reviewer: Shubhendu Tripathi <shtripat at redhat.com>
Gerrit-Reviewer: Timothy Asir <tjeyasin at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list