Change in vdsm[master]: gluster: add createBrick verb

piotr.kliczewski at gmail.com piotr.kliczewski at gmail.com
Fri Feb 6 08:41:21 UTC 2015


Piotr Kliczewski has posted comments on this change.

Change subject: gluster: add createBrick verb
......................................................................


Patch Set 13:

(1 comment)

http://gerrit.ovirt.org/#/c/35498/13/vdsm/gluster/apiwrapper.py
File vdsm/gluster/apiwrapper.py:

Line 80: 
Line 81:     def storageDevicesList(self, options=None):
Line 82:         return self._gluster.storageDevicesList()
Line 83: 
Line 84:     def createBrick(self, name, mountPoint, devList, raidParams):
> Will it be ok to have raidParams={} or it should be like raidParams=None
It is up to you which default value to use but please be consistent with api.py.
Line 85:         return self._gluster.createBrick(name, mountPoint,
Line 86:                                          devList, raidParams)
Line 87: 
Line 88: 


-- 
To view, visit http://gerrit.ovirt.org/35498
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic47c4c56834deb457ae9d038f77bcf69c7b39ba5
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Timothy Asir <tjeyasin at redhat.com>
Gerrit-Reviewer: Bala.FA <barumuga at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Darshan N <dnarayan at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Sahina Bose <sabose at redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo at redhat.com>
Gerrit-Reviewer: Shubhendu Tripathi <shtripat at redhat.com>
Gerrit-Reviewer: Timothy Asir <tjeyasin at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list