Change in vdsm[master]: Add feature to create dispersed volume

piotr.kliczewski at gmail.com piotr.kliczewski at gmail.com
Wed Feb 4 10:53:21 UTC 2015


Piotr Kliczewski has posted comments on this change.

Change subject: Add feature to create dispersed volume
......................................................................


Patch Set 3: Code-Review-1

(2 comments)

http://gerrit.ovirt.org/#/c/37474/3/vdsm/rpc/vdsmapi-gluster-schema.json
File vdsm/rpc/vdsmapi-gluster-schema.json:

Line 666: #
Line 667: # Since: 4.17.0
Line 668: ##
Line 669: {'type': 'VolumeXtraParms',
Line 670:  'data': {'*disperseCount': 'int', '*redundancyCount': 'int'}}
Here we have inconsistency between the name in description and in type definition.
Line 671: 
Line 672: ##
Line 673: # @GlusterVolume.create:
Line 674: #


Line 694: # Since: 4.10.3
Line 695: ##
Line 696: {'command': {'class': 'GlusterVolume', 'name': 'create'},
Line 697:  'data': {'volumeName': 'str', 'bricklist': ['str'],
Line 698:           '*replicaCount': 'int', '*stripeCount': 'int',
Please update *Count name here as well.
Line 699:           '*transportList': ['transType'], '*force': 'bool',
Line 700:           '*options': 'VolumeXtraParms'},
Line 701:  'returns': 'UUID'}
Line 702: 


-- 
To view, visit http://gerrit.ovirt.org/37474
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I50f6dbae8d179c09480634c64d7d439ae82d72a2
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Timothy Asir <tjeyasin at redhat.com>
Gerrit-Reviewer: Bala.FA <barumuga at redhat.com>
Gerrit-Reviewer: Darshan N <dnarayan at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Ramesh N <rnachimu at redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose at redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo at redhat.com>
Gerrit-Reviewer: Shubhendu Tripathi <shtripat at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list