Change in vdsm[master]: gluster: geo-replication configuration related verbs.

piotr.kliczewski at gmail.com piotr.kliczewski at gmail.com
Mon Feb 2 14:51:24 UTC 2015


Piotr Kliczewski has posted comments on this change.

Change subject: gluster: geo-replication configuration related verbs.
......................................................................


Patch Set 10:

(1 comment)

http://gerrit.ovirt.org/#/c/30162/10/vdsm/rpc/vdsmapi-gluster-schema.json
File vdsm/rpc/vdsmapi-gluster-schema.json:

Line 1564: # True if it sets value to the option successfully
Line 1565: #
Line 1566: # Since: 4.17.0
Line 1567: ##
Line 1568: {'command': {'class': 'GlusterVolume', 'name': 'geoRepConfigSet'},
What do you think about change option to optionName and value to optionValue. In the schema we have explanation but in api.py we have option and options and it is not easy to understand what that is for.
Line 1569:  'data': {'volumeName': 'str', 'remoteHost': 'str',
Line 1570:           'remoteVolumeName': 'str', 'option': 'str', 'value': 'str'},
Line 1571:  'returns': 'bool'}
Line 1572: 


-- 
To view, visit http://gerrit.ovirt.org/30162
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifee571dbf3c56633e415d32f8d518cb64aaf1add
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Darshan N <dnarayan at redhat.com>
Gerrit-Reviewer: Bala.FA <barumuga at redhat.com>
Gerrit-Reviewer: Darshan N <dnarayan at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Sahina Bose <sabose at redhat.com>
Gerrit-Reviewer: Timothy Asir <tjeyasin at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list