Change in vdsm[master]: vm: Fix LSM when using libvirt >= 1.2.8

eric.b.blake at gmail.com eric.b.blake at gmail.com
Tue Feb 24 18:20:49 UTC 2015


Eric Blake has posted comments on this change.

Change subject: vm: Fix LSM when using libvirt >= 1.2.8
......................................................................


Patch Set 1:

> (1 comment)
 > 
 > Comment typo in the code, but the logic is correct.

Oh, and you also need to be sure that vdsm will never be compiled against newer libvirt-python (that has the constant) while driving older libvirtd (that lacks support for the constant), which may be possible by judicious version dependencies in .spec files.  If this is not possible, then you may want to enhance the vm.py file to have a fallback that recognizes the 'unknown flag' error and falls back to trying a second time without the flag, if you ever have a case where the libvirt-python on the client machine making the call is newer than the libvirtd on the server machine implementing the call.

-- 
To view, visit https://gerrit.ovirt.org/38142
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idf8a53db81b61378ca00ffb8bf069ae944b78db7
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Eric Blake <eric.b.blake at gmail.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No


More information about the vdsm-patches mailing list