Change in vdsm[master]: vdsm: marked headers as optional in ImageSharingMethodArgsHttp

nsoffer at redhat.com nsoffer at redhat.com
Fri Feb 27 22:09:04 UTC 2015


Nir Soffer has posted comments on this change.

Change subject: vdsm: marked headers as optional in ImageSharingMethodArgsHttp
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.ovirt.org/#/c/38145/2//COMMIT_MSG
Commit Message:

Line 8: 
Line 9: while inspecting the code to update documentation for
Line 10: downloadImage, I determined that the headers parameter
Line 11: is optional for ImageSharingMethodArgsHttp, but was
Line 12: not marked as such
This is better, but this explain why *you* sent it, but not why *we* want to use this.

I think think we want this because it makes the api easier to use. Having to send "headers": {} is not fun.
Line 13: 
Line 14: Change-Id: I2a32f130830e4bdf078de41703484679e4bd7d82


-- 
To view, visit https://gerrit.ovirt.org/38145
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2a32f130830e4bdf078de41703484679e4bd7d82
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Candace Sheremeta <cshereme at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Candace Sheremeta <cshereme at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list