Change in vdsm[master]: hostdev: add check for hostdev passthrough to caps
danken at redhat.com
danken at redhat.com
Fri Feb 27 10:26:39 UTC 2015
Dan Kenigsberg has posted comments on this change.
Change subject: hostdev: add check for hostdev passthrough to caps
......................................................................
Patch Set 8: Code-Review-1
(1 comment)
setting -1 for visibility; the request is only for a commit message change.
https://gerrit.ovirt.org/#/c/30471/8//COMMIT_MSG
Commit Message:
Line 5: CommitDate: 2015-02-26 16:10:35 +0100
Line 6:
Line 7: hostdev: add check for hostdev passthrough to caps
Line 8:
Line 9: Detecting whether the user has enabled iommu can be done through
Could you give me (in the commit message) a little more background about this?
* what is Fedora and EL7's default for this?
* is there not a safer way to check this on a running kernel (kernel command line can change)
* what is the effect of unsupported iommu?
Line 10: checking kernel cmdline for occurence of iommu (AMD) or intel_iommu
Line 11: (well, Intel). This patch exposes this fact in caps, making it
Line 12: possible for engine to warn user about possible inconsistence
Line 13: or impossibility of using hostdev passthrough.
--
To view, visit https://gerrit.ovirt.org/30471
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I789f93679740e87b2f5a88351261bc58852990d4
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Martin Betak <mbetak at redhat.com>
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list